list.sh: fix arg parsing always failing

[Bo98]

Turns out this script has never worked.

[ZhongRuoyu]

Thanks! Completion is now indeed much faster. Could this work for brew ls too? That's an internal alias but it's still routed to cmd/list.rb.

[carlocab]

Why not just do shift in the case block above?

[Bo98]

Could this work for brew ls too?

Yeah, will do this later today (separate PR probably).

Why not just do shift in the case block above?

This logic is borrowed from other files like command_path.sh.

I guess the initial idea was to avoid tampering the args as we conditionally fallback to *.rb but that probably doesn't happen since this is in a function. Could look into refactoring them all.

[MikeMcQuaid]

Thanks @Bo98!

[MikeMcQuaid]

Turns out this script has never worked.

@Bo98 Could you elaborate a bit more here (and on future PRs): what specifically has never worked and why? This pull request message does not reveal this information 😁

[Bo98]

what specifically has never worked and why?

The whole thing. Because $1 == list it will always hit the return 1 case of the argument parsing loop and fallback to list.rb.

So all the code below never ran, and had errors anyway like undefined ohai which the source line also fixes.

[MikeMcQuaid]

@Bo98 Thanks for clarifying!