shims/super/cc: do not pass -pipe #18231
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been wondering for a long time why we pass
-pipe
to C compilers systematically.At least, it did not hurt. Well, until clang 16 broke pipe input to the assembler: there, passing
-pipe
can make GCC actually fail to compile. See OpenMathLib/OpenBLAS#4888 for details.I'll be filing a bug with Apple about that (it's a regression in clang), but I don't expect it to be fixed soon. Given that
-pipe
use is historical, I think it's time to say goodbye to it.