startup/bootsnap: base key on in install state rather than projection #18246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
approved these changes
Sep 4, 2024
toobuntu
added a commit
to toobuntu/babble
that referenced
this pull request
Dec 2, 2024
Highlights: - fix: Resolve syntax error by ensuring variables are nonempty. - feat: Workaround Homebrew issue by handling a corrupt cache. - See https://github.com/orgs/Homebrew/discussions/5226. - Possibly addressed in: - Homebrew/brew#16977 - Homebrew/brew#18240 - Homebrew/brew#18246 - feat: Prepare for feature (not yet implemented) to quit apps prior to upgrade, reinstall, uninstall and relaunch after upgrade and reinstall.
toobuntu
added a commit
to toobuntu/babble
that referenced
this pull request
Dec 2, 2024
Highlights: - fix: Resolve syntax error by ensuring variables are nonempty. - feat: Workaround Homebrew issue by handling a corrupt cache. - See https://github.com/orgs/Homebrew/discussions/5226. - Possibly addressed in: - Homebrew/brew#16977 - Homebrew/brew#18240 - Homebrew/brew#18246 - feat: Prepare for feature (not yet implemented) to quit apps prior to upgrade/reinstall/uninstall and relaunch after upgrade and reinstall.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of keying based on what we intend to install, key instead based on what is actually installed. Otherwise the Bootsnap cache might populate before the install changes have taken place.