Globally silence default gem warnings #18259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bo98
force-pushed
the
silence-default-gems-warnings
branch
from
e6e878e
to
eb5f476
Compare
MikeMcQuaid
approved these changes
Sep 5, 2024
| [Kernel.singleton_class, Kernel].each do |kernel_class| | ||
| next unless kernel_class.respond_to?(:no_warning_require, true) | ||
|
|
||
| kernel_class.alias_method :require, :no_warning_require |
There was a problem hiding this comment.
Can this use the Warning gem instead? Feels like a nicer API if possible.
There was a problem hiding this comment.
We already did but it never worked. I got spammed with base64 warnings every time I ran brew tests.
Ruby 3.3.5 also makes it significantly unclearer what needs it. fiddle is an obvious one but it seems that json and irb now need it too despite not being deprecated, because internally they use code that still depends on other deprecated bundled gems.
There was a problem hiding this comment.
Cool, this approach makes sense then, thanks 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we're going to get spammed even more in Ruby 3.3.5, in ways that are arguably upstream bugs (
require "json"now issues a deprecation warning for its internal code).