Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curl#curl_headers: Work with 56 exit_status #18279

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

samford
Copy link
Member

@samford samford commented Sep 7, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

I previously added the 8 curl exit code (weird server reply) to the list of non-success exit codes that #curl_headers will handle. We're now seeing failures with a 56 exit code (failure in receiving network data), where the server returns a 4xx response for a HEAD request but the same request using GET works as expected (e.g., casks like beeper, get-api, odrive, ui, etc.).

This adds 56 to the list of exit codes in #curl_headers, so a response with a 4xx HTTP status will be automatically retried using GET.

I previously added the 8 curl exit code (weird server reply) to the
list of non-success exit codes that `#curl_headers` will handle.
We're now seeing failures with a 56 exit code (failure in receiving
network data), where the server returns a 4xx response for a `HEAD`
request but the same request using `GET` works as expected (e.g.,
casks like `beeper`, `get-api`, `odrive`, `ui`, etc.).

This adds 56 to the list of exit codes in `#curl_headers`, so a
response with a 4xx HTTP status will be automatically retried using
`GET`.
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@p-linnane p-linnane merged commit 40648b5 into Homebrew:master Sep 9, 2024
27 checks passed
@MikeMcQuaid
Copy link
Member

Thanks @samford!

@samford samford deleted the curl-work-with-56-exit_status branch September 9, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants