style: resolve symblic links in HOMEBREW_CACHE
#18328
Merged
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bo98
approved these changes
Sep 16, 2024
On Linux HOMEBREW_CACHE may be set to `$HOME/.cache/Homebrew`. Some systems, like Fedora Silverblue, have `/home` set up to be a symbolic link to `/var/home`. While Homebrew generally seems to work fine on Fedora Silverblue, rubocop causes the `brew style` command to emit a lot of warnings because of the symbolic link[1]. This can be resolved by looking up the real path of HOMEBREW_CACHE before passing it to rubocop. [1] rubocop/rubocop#6228 Co-authored-by: Bo Anderson <mail@boanderson.me>
notfirefox
force-pushed
the
fix-rubocop-cache
branch
from
d37d3f8
to
bb4208e
Compare
|
Good idea, thanks @notfirefox! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux HOMEBREW_CACHE may be set to
$HOME/.cache/Homebrew. Some systems, like Fedora Silverblue, have/homeset up to be a symbolic link to/var/home. While Homebrew generally seems to work fine on Fedora Silverblue, rubocop causes thebrew stylecommand to emit a lot of warnings because of the symbolic link[1]. This can be resolved by looking up the real path of HOMEBREW_CACHE before passing it to rubocop.[1] rubocop/rubocop#6228
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?