Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli/named_args: silence package_conflicts_message with --quiet #18330

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Based on feedback from Homebrew/discussions#5602.

While users can already silence this by passing --formula or --cask
as required, I am inclined to agree that --quiet should probably
silence messages that are relatively low priority (of which I think this
is one).

Based on feedback from Homebrew/discussions#5602.

While users can already silence this by passing `--formula` or `--cask`
as required, I am inclined to agree that `--quiet` should probably
silence messages that are relatively low priority (of which I think this
is one).
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks @carlocab!

@MikeMcQuaid MikeMcQuaid merged commit 8fd78bf into master Sep 16, 2024
27 checks passed
@MikeMcQuaid MikeMcQuaid deleted the package-conflicts-message-quiet branch September 16, 2024 16:00
carlocab added a commit that referenced this pull request Sep 16, 2024
Let's also show users the right way to silence this message.

Follow-up to #18330.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants