Revert "Limit usage of GitHub Actions Annotations" #18340
Merged
+5
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
carlocab
approved these changes
Sep 16, 2024
|
Would be nice to have an opt out for these with something like |
|
@carlocab Agreed with your suggestions, thanks for that.
Disagree for now, I'd rather we improved these warnings instead. |
carlocab
approved these changes
Sep 16, 2024
MikeMcQuaid
force-pushed
the
revert-18329-limit-annotations
branch
from
f120d02
to
1c39009
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry @carlocab, just reverting this for now so it doesn't make it into the next stable release.
I want to keep these errors around for users but avoid doing the
opoocalls when it doesn't make sense to do so.Reverts #18329