Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search: allow @ and + characters #18345

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

daeho-ro
Copy link
Member

@daeho-ro daeho-ro commented Sep 17, 2024

Allow @ and + characters for search string.

brew search @11
==> Formulae
ant@1.10           go@1.17            llvm@11            mariadb@11.5
cairomm@1.14       go@1.18            mariadb@11.0       openjdk@11
cairomm@1.18       go@1.19            mariadb@11.1       openssl@1.1
clang-format@11    hdf5@1.10          mariadb@11.2       postgresql@11
gcc@11             hdf5@1.14          mariadb@11.4       spidermonkey@115

==> Casks
115                       ableton-live-suite@11     semeru-jdk-open@11
ableton-live-intro@11     corretto@11               temurin@11
ableton-live-lite@11      microsoft-openjdk@11      zulu@11
ableton-live-standard@11  paragon-extfs@11
brew search +
==> Formulae
bonnie++                  libsigc++                 mysql-connector-c++
crf++                     libsigc++@2               pcre++
crypto++                  libxml++                  png++
dvd+rw-tools              libxml++@3                quantum++
gtk+                      libxml++@4                vera++
gtk+3                     libxml++@5                voro++
kimwitu++                 mysql++

==> Casks
4k-video-downloader+      font-rounded-m+           qlc+
easy-move+resize          iina+                     starnet++
font-m+                   intel-psxe-ce-c++         tla+-toolbox
font-m+-nerd-font         logi-options+             xournal++
Warning: Did you mean to perform a regular expression search?
Surround your query with /slashes/ to search locally by regex.

If it is intended to exclude those characters, please ignore this.
I know the only allowing [a-z\d] characters will simplify the search complexity, still cool.


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@daeho-ro daeho-ro changed the title allow @ and + characters for search search: allow @ and + characters for search Sep 17, 2024
@daeho-ro daeho-ro changed the title search: allow @ and + characters for search search: allow @ and + characters Sep 17, 2024
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; makes sense to me!

@MikeMcQuaid
Copy link
Member

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @daeho-ro!

@MikeMcQuaid MikeMcQuaid merged commit 6c39a58 into Homebrew:master Sep 17, 2024
27 checks passed
@daeho-ro
Copy link
Member Author

@MikeMcQuaid Actually, it is my second :)

@daeho-ro daeho-ro deleted the add-search-characters branch September 17, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants