Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubocops: xcodebuild needs an Xcode dependency #18346

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Sep 17, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Since xcodebuild isn't part of CLT so build will fail.

Should be okay on Linux as depends_on :xcode/depends_on xcode: ... is a no-op.

Seperately, may look into either setting DEVELOPER_DIR or using absolute path to Xcode.app since xcode-select --switch /Library/Developer/CommandLineTools will cause build to fail, e.g.

DEVELOPER_DIR=/Applications/Xcode.app xcodebuild --help 2>&1 | head -1
Usage: xcodebuild [-project <projectname>] [[-target <targetname>]...|-alltargets] [-configuration <configurationname>] [-arch <architecture>]... [-sdk [<sdkname>|<sdkpath>]] [-showBuildSettings [-json]] [<buildsetting>=<value>]... [<buildaction>]...

~DEVELOPER_DIR=/Library/Developer/CommandLineTools xcodebuild --help 2>&1 | head -1
xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

@cho-m cho-m marked this pull request as ready for review September 18, 2024 00:34
@MikeMcQuaid MikeMcQuaid merged commit e220725 into Homebrew:master Sep 18, 2024
27 checks passed
@MikeMcQuaid
Copy link
Member

Thanks again @cho-m!

@cho-m cho-m deleted the xcodebuild-dep branch September 18, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants