env_config: deprecate setting boolean vars to falsy values #18408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlocab
force-pushed
the
falsy-env_config
branch
from
648b0e5 to
d9a69cb
Compare
MikeMcQuaid
approved these changes
Sep 25, 2024
carlocab
commented
Sep 25, 2024
MikeMcQuaid
approved these changes
Sep 25, 2024
carlocab
force-pushed
the
falsy-env_config
branch
2 times, most recently
from
e5f842f to
4e7037b
Compare
The way we handle boolean environment variables is a bit unfortunate. For example, setting `HOMEBREW_EVAL_ALL=false` actually enables `HOMEBREW_EVAL_ALL`. Let's fix this by deprecating setting boolean environment variables to common false-y values (`false`, `0`, `nil`, `no`, and `off`) so that we can later ignore these false-y values when reading boolean environment variables.
carlocab
force-pushed
the
falsy-env_config
branch
from
4e7037b to
78065c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?The way we handle boolean environment variables is a bit unfortunate.
For example, setting
HOMEBREW_EVAL_ALL=falseactually enablesHOMEBREW_EVAL_ALL.Let's fix this by deprecating setting boolean environment variables to
common false-y values (
false,0,nil,no, andoff) so that wecan later ignore these false-y values when reading boolean environment
variables.
Note: I haven't commented out
odeprecatedbecause I meant to target the PR branch at #18388, but that seems to have merged just before I pushed this.