Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Delegator DSL compiler #18520

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Add a Delegator DSL compiler #18520

merged 1 commit into from
Oct 7, 2024

Conversation

dduugg
Copy link
Member

@dduugg dduugg commented Oct 6, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Introduces a compiler for Delegtor subclasses. We currently only have two: LazyObject, with no custom methods, and Cask::URL which only delegates to attrs. Thus the compiler is fairly simple and does not even contemplate methods with parameters, all that is enough to replace the hand-rolled rbi file.

Resolves the TODO in Library/Homebrew/cask/url.rbi (cc @Bo98)

@dduugg dduugg force-pushed the delegator-compiler branch from 6d10c5d to b49e696 Compare October 6, 2024 02:07
@dduugg dduugg force-pushed the delegator-compiler branch 2 times, most recently from 88bb0e6 to 9f13ddc Compare October 6, 2024 02:13
@dduugg dduugg force-pushed the delegator-compiler branch from 9f13ddc to 6eaf122 Compare October 6, 2024 02:36
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dduugg!

@dduugg dduugg merged commit 69941c0 into master Oct 7, 2024
28 checks passed
@dduugg dduugg deleted the delegator-compiler branch October 7, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants