-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
os/mac/pkgconfig: add bzip2.pc for rust formulae #18545
Conversation
Didn't even realise there was headers in the SDK for this. Nice!
Any reason for this? Seems safe enough to have
Seems like it's good for all OS versions (though note that pre-10.14 files are slightly different). macOS 12 and later use v1.0.8. Also add a test to |
We should probably fix that. |
No major reason so can add.
Part of issue is latest Future 1.1.0 fixes this, but slightly complicates things due to switch to |
Added for older macOS excluding 10.9 and 10.10 directories (wasn't sure if there was any use for these given outside |
Technically speaking someone could have never upgraded |
As an example, I have tried building ❯ brew linkage uv
System libraries:
/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation
/System/Library/Frameworks/Security.framework/Versions/A/Security
/usr/lib/libSystem.B.dylib
/usr/lib/libbz2.1.0.dylib
/usr/lib/libiconv.2.dylib Existing bottle: ❯ brew linkage uv
System libraries:
/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation
/System/Library/Frameworks/Security.framework/Versions/A/Security
/usr/lib/libSystem.B.dylib
/usr/lib/libiconv.2.dylib |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Mainly since the only way to avoid bundled
bzip2
in rust formulae is viapkg-config
- https://github.com/alexcrichton/bzip2-rs/blob/master/bzip2-sys/build.rs#L16-L23Similar to pkgconfig file created inside
bzip2
formula based on https://gitlab.com/bzip2/bzip2/-/blob/master/bzip2.pc.in (note that we currently only ship shared libraries & pkg-config file on Linux, so using brewbzip2
is particularly bad option on macOS).Removed
bindir=
and-I${includedir}
in Cflags.Only added macOS 15 for initial discussion. If acceptable, can add older macOS versions.