Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula_auditor: allow pkg-config alias for pkgconf migration #18675

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Oct 30, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

We've discussed migrating pkg-config to pkgconf a couple times, e.g. Homebrew/homebrew-core#194885

One of requirements is retaining compatibility with wide usage of depends_on "pkg-config" which seems to be best handled through an alias and this audit exception.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge once there's a comment!

Library/Homebrew/formula_auditor.rb Show resolved Hide resolved
@cho-m cho-m force-pushed the formula_auditor-pkgconf branch from 04d1747 to 347e946 Compare November 1, 2024 16:42
@p-linnane p-linnane merged commit 4d0deeb into master Nov 3, 2024
27 checks passed
@p-linnane p-linnane deleted the formula_auditor-pkgconf branch November 3, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants