Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github_runner_matrix: extend timeout for dependent tests on arm64 #18689

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Nov 1, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

We give our ARM runners half the timeout of the Intel runners because
the ARM runners are faster. However, this is no longer true for
dependent testing because we test recursive dependents on ARM but skip
them on Intel.

This means that we can often hit the timeout on ARM but have all jobs
finish on Intel. We can re-run these with the long build label, but
that's a bit wasteful of our limited long build slots.

Instead, let's just use the same timeout value across ARM and Intel
runners when testing dependents: 2 hours.

We give our ARM runners half the timeout of the Intel runners because
the ARM runners are faster. However, this is no longer true for
dependent testing because we test recursive dependents on ARM but skip
them on Intel.

This means that we can often hit the timeout on ARM but have all jobs
finish on Intel. We can re-run these with the long build label, but
that's a bit wasteful of our limited long build slots.

Instead, let's just use the same timeout value across ARM and Intel
runners when testing dependents: 2 hours.
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks @carlocab!

@carlocab carlocab merged commit c69b5e7 into master Nov 1, 2024
27 checks passed
@carlocab carlocab deleted the longer-deps-timeout branch November 1, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants