Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tap: allow an array of values for an audit exception #18717

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

bevanjkay
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Discovered in Homebrew/homebrew-cask#191078
The audit fails due to a specific HTTP error, on two URLs within the one cask.
Presently, it isn't possible to pass two URLs to a single token via an array in the audit_exception list because the value isn't read.

This PR correctly parses the array.

Library/Homebrew/tap.rb Outdated Show resolved Hide resolved
Library/Homebrew/tap.rb Outdated Show resolved Hide resolved
Library/Homebrew/tap.rb Outdated Show resolved Hide resolved
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bevanjkay!

@MikeMcQuaid MikeMcQuaid merged commit 3ff3ad6 into Homebrew:master Nov 6, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants