Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Portable Ruby 3.3.6 #18718

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Portable Ruby 3.3.6 #18718

merged 2 commits into from
Nov 6, 2024

Conversation

p-linnane
Copy link
Member

@p-linnane p-linnane commented Nov 6, 2024 •
edited
Loading

@p-linnane
Portable Ruby 3.3.6
3019e0a 
Signed-off-by: Patrick Linnane <patrick@linnane.io>
Bo98
Bo98 approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if you do brew vendor-gems --update=--ruby and push to bump the Ruby version in Gemfile.lock.

@p-linnane p-linnane merged commit 5e5d02a into master Nov 6, 2024
29 checks passed
@p-linnane p-linnane deleted the portable-ruby-3.3.6 branch November 6, 2024 00:23
@MikeMcQuaid
Copy link
Member

Thanks @p-linnane and @Bo98!

@MikeMcQuaid
Copy link
Member

Looks good if you do brew vendor-gems --update=--ruby and push to bump the Ruby version in Gemfile.lock.

Could consider automating this given we have a job that will run brew vendor-gems in some PRs already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bo98 Bo98 Bo98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@p-linnane @MikeMcQuaid @Bo98