Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate-cask-ci-matrix: fix incorrect error being raised #18783

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

bevanjkay
Copy link
Member

@bevanjkay bevanjkay commented Nov 17, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

The comparison between the working directory and tap path did not function correctly on GitHub actions, because we don't checkout the tap to a standard location when using Setup Homebrew.
The command must be run from within the tap directory, which is the default path in GitHub actions, so this should not be an issue.

@bevanjkay bevanjkay force-pushed the generate-cask-ci-matrix-fix branch 2 times, most recently from 1824ab8 to 75b4fd3 Compare November 17, 2024 13:49
@bevanjkay bevanjkay force-pushed the generate-cask-ci-matrix-fix branch from 75b4fd3 to 14301c6 Compare November 18, 2024 00:24
@bevanjkay bevanjkay force-pushed the generate-cask-ci-matrix-fix branch from 14301c6 to 597f5fa Compare November 18, 2024 02:00
@MikeMcQuaid MikeMcQuaid merged commit 7de8d2d into Homebrew:master Nov 18, 2024
28 checks passed
@MikeMcQuaid
Copy link
Member

Thanks @bevanjkay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants