uninstall: don't ignore deps even for developers #18784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was discussed a while back on Slack. The idea behind this is that ignoring dependencies during `brew uninstall` makes it too easy to break things, even for developers. Those who know what they are doing can, and IMO should, always use the `--ignore-dependencies` flag.
Bo98
approved these changes
Nov 17, 2024
There was a problem hiding this comment.
Fine with me but when merging be cautious of test-bot breakages e.g. perhaps https://github.com/Homebrew/homebrew-test-bot/blob/da3b57b360af962b306152f50d7f9b470d5208bd/lib/tests/formulae.rb#L613.
reitermarkus
approved these changes
Nov 17, 2024
ZhongRuoyu
added a commit
to Homebrew/homebrew-test-bot
that referenced
this pull request
Nov 18, 2024
Since Homebrew/brew#18784 `brew uninstall` requires the `--ignore-dependencies` option to be used explicitly. Fixes failure seen at https://github.com/Homebrew/homebrew-core/actions/runs/11889490048/job/33126293058?pr=198065.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?This was discussed a while back on Slack. The idea behind this is that ignoring dependencies during
brew uninstallmakes it too easy to break things, even for developers. Those who know what they are doing can, and IMO should, always use the--ignore-dependenciesflag.