Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update redirecting url #18813

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Conversation

samford
Copy link
Member

@samford samford commented Nov 24, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

A php.net URL in docs/Versions.md is redirecting to www.php.net, so this updates the URL to avoid the redirection. I noticed this because php.net was having server issues (timing out) and the docs job on brew CI was failing with the following:

For the Links > External check, the following failures were found:

* At ./_site/Versions.html:65:

  External link https://php.net/supported-versions.php failed: got a time out (response code 301) (status code 301)


HTML-Proofer found 1 failure!

The server issue was addressed upstream, so this PR just addresses the redirection (which isn't a failure now that the server is available again).

A php.net URL in `docs/Versions.md` is redirecting to www.php.net, so
this updates the URL to avoid the redirection.
@EricFromCanada EricFromCanada merged commit 6adec38 into master Nov 24, 2024
28 checks passed
@EricFromCanada EricFromCanada deleted the docs-update-redirecting-php-url branch November 24, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants