Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorbet: Bump some Cask files to typed: strict #18824

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Nov 26, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@issyl0 issyl0 force-pushed the bump-cask-files-to-sorbet-strict branch from 690e0b9 to f923ac5 Compare November 26, 2024 00:25
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@issyl0 issyl0 marked this pull request as ready for review November 26, 2024 10:02
@issyl0 issyl0 merged commit 6fb9d2d into master Nov 26, 2024
28 checks passed
@issyl0 issyl0 deleted the bump-cask-files-to-sorbet-strict branch November 26, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants