Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubocops/uses_from_macos: allow using Sequoia jq #18826

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Nov 26, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

I think jq was added in Sequoia:

/usr/bin/jq --version
jq-1.6-159-apple-gcff5336-dirty

So could use it as dependency via uses_from_macos "jq", since: :sequoia

Probably not going to make formula keg_only so adding to UsesFromMacos rather than ProvidedByMacos given comment:

# These formulae aren't `keg_only :provided_by_macos` but are provided by
# macOS (or very similarly, e.g. OpenSSL where system provides LibreSSL).

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@MikeMcQuaid MikeMcQuaid merged commit 7e86ca1 into master Nov 26, 2024
26 checks passed
@MikeMcQuaid MikeMcQuaid deleted the macos-jq branch November 26, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants