Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/update: avoid switching developers to stable branch #18858

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Dec 3, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Checking for HOMEBREW_NO_INSTALL_CLEANUP was added in #18825, but this
breaks developers by switching them to the stable branch.

Setting HOMEBREW_NO_UPDATE_CLEANUP when HOMEBREW_NO_INSTALL_CLEANUP
is set seems like a relatively recent addition, so I don't think it
hurts to just remove it. We can add it back (correctly) if there are
users that need it.

Checking for `HOMEBREW_NO_INSTALL_CLEANUP` was added in #18825, but this
breaks developers by switching them to the stable branch.

Setting `HOMEBREW_NO_UPDATE_CLEANUP` when `HOMEBREW_NO_INSTALL_CLEANUP`
is set seems like a relatively recent addition, so I don't think it
hurts to just remove it. We can add it back (correctly) if there are
users that need it.
@carlocab carlocab enabled auto-merge December 3, 2024 17:36
@carlocab carlocab merged commit b854d17 into master Dec 3, 2024
26 checks passed
@carlocab carlocab deleted the update-fix branch December 3, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants