Fix systemd command line quoting #18865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need a way to escape systemd command lines properly as systemd treats unrecognised escape sequences as separate literal characters. This helper function does that.
Fixes #18802 (affected formulae still need rebuilding).
p-linnane
approved these changes
Dec 3, 2024
MikeMcQuaid
approved these changes
Dec 4, 2024
This was referenced Dec 4, 2024
apainintheneck
added a commit
that referenced
this pull request
Dec 7, 2024
This was originally added in #18865. ```console $ brew ruby -e 'p "activemq".f.service.to_systemd_unit' /usr/local/Homebrew/Library/Homebrew/service.rb:458:in `block in to_systemd_unit': uninitialized constant Utils::Service (NameError) from /usr/local/Homebrew/Library/Homebrew/service.rb:458:in `map' from /usr/local/Homebrew/Library/Homebrew/service.rb:458:in `to_systemd_unit' from /usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/3.3.0/gems/sorbet-runtime-0.5.11685/lib/types/private/methods/call_validation.rb:278:in `bind_call' from /usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/3.3.0/gems/sorbet-runtime-0.5.11685/lib/types/private/methods/call_validation.rb:278:in `validate_call' from /usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/3.3.0/gems/sorbet-runtime-0.5.11685/lib/types/private/methods/_methods.rb:277:in `block in _on_method_added' from -e:1:in `<main>' ``` ```console $ brew ruby -e 'p "activemq".f.service.to_systemd_unit' "[Unit]\nDescription=Homebrew generated unit for activemq\n\n[Install]\nWantedBy=default.target\n\n[Service]\nType=simple\nExecStart=\"/usr/local/opt/activemq/bin/activemq\" \"console\"\nWorkingDirectory=/usr/local/opt/activemq/libexec\n" ```
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?We need a way to escape systemd command lines properly as systemd treats unrecognised escape sequences as separate literal characters. So, a helper function
Utils::Service::systemd_quoteis added and used for generation of systemd unit config files, replacingUtils::Shell::sh_quote.Fixes #18802 (affected formulae
still need rebuildingcan be fixed bybrew reinstallas service file is re-generated at install time).