livecheck: refactor HEAD-only formula handling #19338
Merged
+20
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?The existing code for handling a
HEAD
-only formula involves two return values that can benil
but this isn't apparent because the related methods aren't typed. This adds type signatures to the methods and updates the livecheck code to account fornil
return values (making it clear which methods can returnnil
). This addressesT.must
usage in the same code in #19323.Besides that, this also extracts the "Unable to get versions" error message into a constant, like
NO_CURRENT_VERSION_MSG
.