-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zig template and std args #19346
Zig template and std args #19346
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, nice work!
Should this be Intel and/or ARM only? Look at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for your contribution! Without people like you submitting PRs we couldn't run this project. You rock, @botantony!
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Standard args and a template for Zig project.
I am not sure what would be the best release mode, I think
fast
is the best option for Homebrew. I also wanted to explicitly include-fno-rosetta
flag for macOS build but this code fails tests:P.S.: on my machine tests fail on
Homebrew::DevCmd::TapNew
method but it failed even before these changes. Not sure how to fix it, hope it is not related.