-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
Update Linux GCC code. #19642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Linux GCC code. #19642
Conversation
Need to install Might also require compiler selector changes if it is preferring |
8d66d22
to
f212feb
Compare
Ok so after thinking a little bit about this
|
@iMichka I don't know, I'm OK with trying!
Feels like we should just handle this automatically for them with Docker images/formulae etc. Otherwise: perhaps a
What's the need to move to GCC 13? What is blocked by being on GCC 12 (or even 11)? |
98b9ab0
to
d9f9b08
Compare
I've hit my time box of what I can justify spending on this for now. I've removed the actual version bumps here and scoped this to the refactoring/fixes that were needed that work without the version bumps. The tests (bar formula audit failing which I don't understand) were passing here so this is ready to merge as-is and will make life easier for someone wanting to update these variables in future if they look back at the changes in 98b9ab0 to |
e1690e1
to
1f5e7b1
Compare
Update both the variables that dictate this and the documents that explain our GCC/glibc policies. These should ease a future migration to a newer GCC version.
1f5e7b1
to
2b4324a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Update both the variables that dictate this and the documents that explain our GCC/glibc policies.
These should ease a later future migration to a newer GCC version.
This is based on the conversation in #19238.