dev-cmd/tap-new: support private repos #19839
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This PR ensures that taps created with
brew tap-new
can be private (private repo + private packages) by listing all required permissions and setting the correctHOMEBREW_DOCKER_REGISTRY_TOKEN
for bottles.An alternative approach would be to add a
--private
flag tobrew tap-new
, so that additional permissions are added when it is set.I'm happy to follow that approach if we decide it is better. An argument for the initially proposed approach is that even for public repos, it makes sense to restrict permissions only to the required resources.