Skip to content

dev-cmd/tap-new: support private repos #19839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2025
Merged

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Apr 28, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This PR ensures that taps created with brew tap-new can be private (private repo + private packages) by listing all required permissions and setting the correct HOMEBREW_DOCKER_REGISTRY_TOKEN for bottles.

An alternative approach would be to add a --private flag to brew tap-new, so that additional permissions are added when it is set.
I'm happy to follow that approach if we decide it is better. An argument for the initially proposed approach is that even for public repos, it makes sense to restrict permissions only to the required resources.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bayandin! One thought.

@bayandin bayandin force-pushed the tap-new-for-private-repos branch from 0418e2e to 87046b1 Compare April 28, 2025 16:58
@bayandin bayandin force-pushed the tap-new-for-private-repos branch from 87046b1 to 875702d Compare April 28, 2025 17:07
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @bayandin!

@MikeMcQuaid MikeMcQuaid enabled auto-merge April 29, 2025 07:33
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Apr 29, 2025
Merged via the queue into master with commit 3332d33 Apr 29, 2025
35 checks passed
@MikeMcQuaid MikeMcQuaid deleted the tap-new-for-private-repos branch April 29, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants