Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bottle: Use Parser to parse args #3975

Merged
merged 1 commit into from
Mar 25, 2018
Merged

bottle: Use Parser to parse args #3975

merged 1 commit into from
Mar 25, 2018

Conversation

GauthamGoli
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

#1860

MikeMcQuaid
MikeMcQuaid reviewed Mar 25, 2018
View reviewed changes
Library/Homebrew/dev-cmd/bottle.rb Outdated
@@ -500,7 +499,20 @@ def merge
end

def bottle
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be nice to move this method to the top of the file.

MikeMcQuaid
MikeMcQuaid requested changes Mar 25, 2018
View reviewed changes
Library/Homebrew/dev-cmd/bottle.rb Outdated
switch "--no-commit"
switch "--json"
flag "--root-url"
flag "--root_url"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can kill --root_url now; it was a typod old option but nothing has used it for a very long time now.

Library/Homebrew/dev-cmd/bottle.rb Outdated
flag "--root-url"
flag "--root_url"
end.parse
if @args.merge?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return merge if @args.merge? and then you can skip the else

@MikeMcQuaid MikeMcQuaid merged commit f04de21 into Homebrew:master Mar 25, 2018
@MikeMcQuaid
Copy link
Member

Thanks again @GauthamGoli!

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GauthamGoli @MikeMcQuaid