cli_parser: Add class method to make options declaration more readable #3980

GauthamGoli · 2018-03-25T12:21:46Z

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same change?
Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes? Here's an example.
Have you successfully run brew style with your changes locally?
Have you successfully run brew tests with your changes locally?

MikeMcQuaid · 2018-03-25T12:25:10Z

Library/Homebrew/cli_parser.rb

@@ -4,6 +4,12 @@
 module Homebrew
  module CLI
    class Parser
+      class << self
+        def parse(&block)


def self.parse(&block) would work, right?

yeah, but I read class << self way is more popular in RoR codebase 😬

Nevermind. Changing it to def self.parse(&block)

MikeMcQuaid · 2018-03-25T12:58:03Z

Thanks again @GauthamGoli!

MikeMcQuaid reviewed Mar 25, 2018

View reviewed changes

cli_parser: Add class method to make options declaration more readable

ed38757

GauthamGoli force-pushed the arg-parser-refactor branch from f6de9e4 to ed38757 Compare March 25, 2018 12:32

MikeMcQuaid approved these changes Mar 25, 2018

View reviewed changes

MikeMcQuaid merged commit f37b0bc into Homebrew:master Mar 25, 2018

Homebrew locked and limited conversation to collaborators May 4, 2018

Provide feedback