style: use RuboCop 0.41.2, adjust defaults #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to our style configuration: - Consolidate all rules related to Ruby 1.8 compatibility in one place. - Codify our de-facto preference for `alias_method` over `alias` (drops offense count by 54 after turning this on). - Drop `Style/SignalException` as `only_raise` has been the new default for quite a while (since RuboCop 0.37.0).
| @@ -3,9 +3,13 @@ AllCops: | |||
| - 'Homebrew/vendor/**/*' | |||
| - 'Homebrew/test/vendor/**/*' | |||
|
|
|||
| # 1.8-style hash keys | |||
| # Ruby 1.8 compatibility | |||
There was a problem hiding this comment.
Maybe put all these last in the file?
There was a problem hiding this comment.
I don't have a strong preference. It felt nice to “reuse” this comment and to keep it at the top as a constant reminder for every reader of this file that we're still stuck with Ruby 1.8 (until this is no longer the case).
There was a problem hiding this comment.
Sorry, I see now it's right at the top. Seems fine 👍
|
👍 |
1 similar comment
|
👍 |
souvik1997
pushed a commit
to souvik1997/brew
that referenced
this pull request
Jul 25, 2016
Changes to our style configuration: - Consolidate all rules related to Ruby 1.8 compatibility in one place. - Codify our de-facto preference for `alias_method` over `alias` (drops offense count by 54 after turning this on). - Drop `Style/SignalException` as `only_raise` has been the new default for quite a while (since RuboCop 0.37.0).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew testswith your changes locally?Changes to our style configuration:
alias_methodoveralias(drops offense count by 54 after turning this on).Style/SignalExceptionasonly_raisehas been the new default for quite a while (since RuboCop 0.37.0).