Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

argv: move options_only to cli/args #6411

Merged
merged 1 commit into from
Sep 9, 2019

Conversation

GauthamGoli
Copy link
Contributor

@GauthamGoli GauthamGoli commented Sep 1, 2019

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

#5730

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! brew style is failing.

Library/Homebrew/cli/args.rb Outdated Show resolved Hide resolved
@GauthamGoli
Copy link
Contributor Author

@MikeMcQuaid Fixed styles.

@MikeMcQuaid MikeMcQuaid merged commit f98efa1 into Homebrew:master Sep 9, 2019
@MikeMcQuaid
Copy link
Member

Thanks again @GauthamGoli!

@GauthamGoli
Copy link
Contributor Author

This implementation is buggy and we would revert it;

Lets say I pass -v switch, then Homebrew.args would have v?=true, verbose?=true
and Homebrew.args.options_only would return both [-v, --verbose] which is wrong,
where as ARGV.options_only correctly returns [-v]

@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants