Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved kegs from ARGV to args.rb #6622

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Conversation

zachauten
Copy link
Contributor

@zachauten zachauten commented Oct 21, 2019

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

#5730

@zachauten
Copy link
Contributor Author

Still a work in progress, meant to open as a draft.

@MikeMcQuaid
Copy link
Member

@zachauten Cool, shout when you're done/need help! @GauthamGoli may have useful thoughts too.

@zachauten
Copy link
Contributor Author

@MikeMcQuaid @GauthamGoli Ready for review!

@MikeMcQuaid MikeMcQuaid merged commit 5904aab into Homebrew:master Nov 13, 2019
@MikeMcQuaid
Copy link
Member

Great work, thanks again @zachauten!

@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants