Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create: cargo install --locked #6664

Merged
merged 1 commit into from
Oct 31, 2019

Conversation

dawidd6
Copy link
Member

@dawidd6 dawidd6 commented Oct 30, 2019

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

I see in homebrew-core recently a trend where maintainers suggest PR authors to append --locked flag to cargo install and it's reasonable.
I thought it might be a good idea to include this in template.

@issyl0
Copy link
Member

issyl0 commented Oct 30, 2019

Relevant Homebrew/homebrew-core PR for this “trend”: Homebrew/homebrew-core#45839

@MikeMcQuaid MikeMcQuaid merged commit aa40b80 into Homebrew:master Oct 31, 2019
@MikeMcQuaid
Copy link
Member

Thanks @issyl0!

@MikeMcQuaid
Copy link
Member

Er, whoops it was @dawidd6, misread! Thanks @dawidd6!

@dawidd6 dawidd6 deleted the create-rust-locked branch October 31, 2019 09:32
@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants