Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python_virtualenv_constants: upgrade virtualenv to 20.0.26 #7941

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

lembacon
Copy link
Member

@lembacon lembacon commented Jul 8, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@MikeMcQuaid MikeMcQuaid merged commit d512374 into Homebrew:master Jul 8, 2020
@MikeMcQuaid
Copy link
Member

Thanks @lembacon!

@Bo98
Copy link
Member

Bo98 commented Jul 8, 2020

While previous versions of virtualenv didn't have any dependencies, virtualenv 20.x does so this currently breaks CI on Catalina:

==> python3.8 -s /private/tmp/snakemake--homebrew-virtualenv-20200708-40521-1n4amgf/target/bin/virtualenv -p python3.8 /usr/local/Cellar/snakemake/5.20.0/libexec
Traceback (most recent call last):
  File "/private/tmp/snakemake--homebrew-virtualenv-20200708-40521-1n4amgf/target/bin/virtualenv", line 6, in <module>
    from pkg_resources import load_entry_point
  File "/usr/local/lib/python3.8/site-packages/pkg_resources/__init__.py", line 3255, in <module>
    def _initialize_master_working_set():
  File "/usr/local/lib/python3.8/site-packages/pkg_resources/__init__.py", line 3238, in _call_aside
    f(*args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/pkg_resources/__init__.py", line 3267, in _initialize_master_working_set
    working_set = WorkingSet._build_master()
  File "/usr/local/lib/python3.8/site-packages/pkg_resources/__init__.py", line 584, in _build_master
    ws.require(__requires__)
  File "/usr/local/lib/python3.8/site-packages/pkg_resources/__init__.py", line 901, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/usr/local/lib/python3.8/site-packages/pkg_resources/__init__.py", line 787, in resolve
    raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'six<2,>=1.9.0' distribution was not found and is required by virtualenv

@vladimyr
Copy link
Contributor

vladimyr commented Jul 9, 2020

While previous versions of virtualenv didn't have any dependencies, virtualenv 20.x does so this currently breaks CI on Catalina

It breaks install from source for any python formula using virtualenv ⚠️
Following dependencies are missing: https://github.com/pypa/virtualenv/blob/20.0.26/setup.cfg#L41-L48

install_requires =
    appdirs>=1.4.3,<2
    distlib>=0.3.1,<1
    filelock>=3.0.0,<4
    six>=1.9.0,<2   # keep it >=1.9.0 as it may cause problems on LTS platforms
    importlib-metadata>=0.12,<2;python_version<"3.8"
    importlib-resources>=1.0;python_version<"3.7"
    pathlib2>=2.3.3,<3;python_version < '3.4' and sys.platform != 'win32'

IMHO this should be reverted as soon as possible until the proper upgrade is made.

@MikeMcQuaid
Copy link
Member

Thanks @Bo98 and @vladimyr.

@vladimyr Check your email! I replied to your one and haven't seen a reply yet.

@lembacon lembacon deleted the virtualenv-20.0.26 branch August 7, 2020 07:17
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 20, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants