-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show cask description in brew cask info
command
#8335
Show cask description in brew cask info
command
#8335
Conversation
If we were planning on descriptions being optional, displaying nothing would be cleaner. But because we want them to be mandatory—and filled as soon as possible—I’d go with |
Also add non-dummy URL in the test fixture, to match the name, version, etc.
84771d3
to
5393218
Compare
Ok, I added a commit adding the |
Fantastic and blazing fast work! Thank you for the continued contributions. |
I had actually implemented it this way at first, so the logic was still in RAM 😄
My pleasure! I'm trying to get this |
Thanks, @waldyrious! |
brew style
with your changes locally?brew tests
with your changes locally?(partially: I ran
brew tests --online --only=cask/cmd/info
, and all tests therein passed.)Actually display Cask descriptions (introduced in #8137) in the output of
brew cask info
.The approach I took here was to not display the description if it doesn't exist, instead of showing
None
as is done for the name(s). Happy to change it to showNone
if that's preferred (as descs are meant to eventually become mandatory). /cc @reitermarkus