-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and document Language::Python
.
#8379
Conversation
Library/Homebrew/language/python.rb
Outdated
PYTHON_VIRTUALENV_SHA256_MOJAVE = | ||
"1d7e241b431e7afce47e77f8843a276f652699d1fa4f93b9d8ce0076fd7b0b54" | ||
private_constant :PYTHON_VIRTUALENV_SHA256_MOJAVE | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Is there a reason why this is not
if MacOS.version PYTHON_VIRTUALENV_URL = ... ... else PYTHON_VIRTUALENV_URL = ... ...
-
Below we use
MacOS.version
but there is norequire "os/mac/version"
orrequire "os/mac"
. Are we sure we don't need it on a Mac? -
On Linux
MacOS.version
defaults toNULL
, so Linux defaults to usingPYTHON_VIRTUALENV_URL_MOJAVE
-- I think it's better to make it default to using virtualenv-16.7.4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really sure how this should behave.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PYTHON_VIRTUALENV_URL_MOJAVE
purely exists for system Python 2, which I don't know if we even have support for anymore.
It shouldn't be applied to brewed Python 3 at least.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can try to kill it here.
b38ccfa
to
da0ff4f
Compare
end | ||
url "https://files.pythonhosted.org/packages/11/74" \ | ||
"/2c151a13ef41ab9fb43b3c4ff9e788e0496ed7923b2078d42cab30622bdf/virtualenv-16.7.4.tar.gz" | ||
sha256 "94a6898293d07f84a98add34c4df900f8ec64a570292279f6d91c781d37fd305" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not in this PR, but we need to consider using a newer version of virtualenv
.
Versions prior to v20.0.0
belong to the "legacy" branch (the latest one being 16.7.10 -- maybe we could use it here even now) and the latest stable is: v20.0.31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using v20 is complicated as it requires a bunch of dependencies.
16.7.10 should be trivial to update to however.
brew style
with your changes locally?brew tests
with your changes locally?Extracted from #8339 for easier review.