Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ZSH completions handling #9292

Merged
merged 1 commit into from
Nov 26, 2020
Merged

Improve ZSH completions handling #9292

merged 1 commit into from
Nov 26, 2020

Conversation

MikeMcQuaid
Copy link
Member

  • Only display the completions caveats from the current shell (assuming it's one of Bash, ZSH or Fish)
  • If the completions location isn't in the ZSH FPATH then link to the documentation explaining how to do so.

Fixes #8984

@BrewTestBot
Copy link
Member

Review period will end on 2020-11-26 at 11:03:01 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Nov 25, 2020
@MikeMcQuaid MikeMcQuaid mentioned this pull request Nov 25, 2020
Closed
yschimke
yschimke approved these changes Nov 25, 2020
View reviewed changes
Copy link

@yschimke yschimke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, one question around 2 suffix, I assume is testing.

@BrewTestBot
Copy link
Member

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Nov 26, 2020
@MikeMcQuaid
Improve ZSH completions handling
3002c81 
- Only display the completions caveats from the current shell (assuming
  it's one of Bash, ZSH or Fish)
- If the completions location isn't in the ZSH `FPATH` then link to the
  documentation explaining how to do so.

Fixes #8984
@MikeMcQuaid MikeMcQuaid merged commit 86631b4 into Homebrew:master Nov 26, 2020
@MikeMcQuaid MikeMcQuaid deleted the improve-zsh-completions branch November 26, 2020 16:56
@NReilingh NReilingh mentioned this pull request Dec 2, 2020
Closed
3 tasks
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 27, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@yschimke yschimke yschimke approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zsh tab completion not active by default
3 participants
@MikeMcQuaid @BrewTestBot @yschimke