Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/update: improve shallow clone message. #9447

Merged
merged 1 commit into from
Dec 7, 2020
Merged

cmd/update: improve shallow clone message. #9447

merged 1 commit into from
Dec 7, 2020

Conversation

MikeMcQuaid
Copy link
Member

This should hopefully avoid getting more issues about this.

@BrewTestBot
Copy link
Member

Review period will end on 2020-12-08 at 15:08:10 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 7, 2020
This was referenced Dec 7, 2020
Merged
Closed
Closed
Closed
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Dec 7, 2020
@BrewTestBot
Copy link
Member

BrewTestBot commented Dec 7, 2020 •
edited
Loading

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 7, 2020
EricFromCanada
EricFromCanada reviewed Dec 7, 2020
View reviewed changes
Library/Homebrew/cmd/update.sh Outdated Show resolved Hide resolved
Library/Homebrew/cmd/update.sh Outdated Show resolved Hide resolved
@MikeMcQuaid MikeMcQuaid merged commit f5f50fe into Homebrew:master Dec 7, 2020
@MikeMcQuaid MikeMcQuaid deleted the no-shallow-clone-clarify branch December 7, 2020 16:05
@rgant
Copy link
Contributor

rgant commented Dec 9, 2020

Those two command are super similar looking. It would be better if they were highlighted as different commands.

@MikeMcQuaid
Copy link
Member Author

@rgant We'll review a PR of your alternate proposal.

@rgant
Copy link
Contributor

rgant commented Dec 10, 2020

Done: #9501

@vitorgalvao vitorgalvao mentioned this pull request Jan 9, 2021
Closed
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 10, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EricFromCanada EricFromCanada EricFromCanada left review comments

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MikeMcQuaid @BrewTestBot @rgant @EricFromCanada