Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

Add Cask for ctop 0.7 #5244

Closed
wants to merge 1 commit into from
Closed

Conversation

pcasaretto
Copy link

https://ctop.sh/

I've been using my own tap, but the owner of the project also thinks it's interesting to have it here on the official repos.
bcicen/ctop#118

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked there are no open pull requests for the same cask.
  • Checked the cask was not already refused in closed issues.
  • Checked the cask is submitted to the correct repo.

@commitay
Copy link
Contributor

@commitay commitay closed this Feb 13, 2018
@commitay
Copy link
Contributor

commitay commented Feb 13, 2018

This is our policy for cli open source binaries.

Rejected Casks
The app is both open-source and CLI-only (i.e. it only uses the binary artifact). In that case, and in the spirit of deduplication, submit it first to Homebrew/core. If it is rejected there, you may then try again in Homebrew-Cask (link us to the issue on Homebrew so we can see their reasoning for rejection).

Basically we will add it only if Homebrew doesn't want it, which does not apply in this case.

@pcasaretto
Copy link
Author

So, having a ready to consume, dependency free version is not interesting for Homebrew Cask?

@commitay
Copy link
Contributor

ready to consume, dependency free

The formula only has build deps.

@pcasaretto
Copy link
Author

Right!
Personally, I choose not to install go using brew, and having a second installation of go in my machine just to build binaries that depend on go is really troubling.
I would love to think of Cask as a tool that would help me download the binaries and link them directly. Is this not a goal of the project? 🤔

@commitay
Copy link
Contributor

Personally, I choose not to install go using brew, and having a second installation of go in my machine just to build binaries that depend on go is really troubling.

If you build from source that is your choice, it isn't the default.

I would love to think of Cask as a tool that would help me download the binaries and link them directly.

We don't duplicate Homebrew formula unless it's for a very good reason (and this isn't one).

@pcasaretto
Copy link
Author

Wow, I'm feeling very dumb now. I was sure there was no bottle option, but even then I should have added it myself there instead of building a cask.
🤦‍♂️
Sorry

@lock lock bot locked as resolved and limited conversation to collaborators May 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants