Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EAP versions of Jetbrains products? #32521

Closed
vitorgalvao opened this issue Apr 18, 2017 · 16 comments
Closed

Remove EAP versions of Jetbrains products? #32521

vitorgalvao opened this issue Apr 18, 2017 · 16 comments

Comments

@vitorgalvao
Copy link
Member

vitorgalvao commented Apr 18, 2017

Refs Homebrew/homebrew-cask-versions#3630 (comment).

Jetbrains casks are constantly being updated. As such the EAP casks are frequently changed to the stable version and then reset to EAP again when new versions are available. We even have users that concentrate mostly on those updates, but even then it’s a non-trivial amount of work for maintainers.

Normally that alone wouldn’t be grounds for removal, but in Jetbrains apps you can change to the update channel you want from inside the app.

image

So I’d suggest that instead of constantly playing catchup for the EAPs, we remove them and keep only the stable versions. If a user wants an EAP version, we recommend they change the channel from inside the stable version. Jetbrains casks are auto_updates true anyway.

@yurikoles
Copy link
Contributor

I can say more: there is Jetbrains Toolbox app that alows you to install any current branch of any app produced by Jetbrains.

@leipert
Copy link
Contributor

leipert commented Apr 18, 2017

As somewhat of a jetbrains cask janitor, I opt for the EAP removal.

@leipert
Copy link
Contributor

leipert commented Apr 18, 2017

The only problem is: how we would handle gogland-eap, as there is no stable version (yet). Either:

  1. move it to the normal caskroom
  2. leave it in versions and move it once it is stable

@vitorgalvao
Copy link
Member Author

vitorgalvao commented Apr 18, 2017

@leipert We should move it to the main repo. We have precedents.

@miccal
Copy link
Member

miccal commented Apr 19, 2017

I agree with @vitorgalvao and @leipert.

@neutric
Copy link
Contributor

neutric commented Apr 19, 2017

I agree as well.

@leipert
Copy link
Contributor

leipert commented Apr 19, 2017

I opened two Pull-Requests:

  1. Removal of jetbrains casks from homebrew-versions: remove all jetbrains casks homebrew-cask-versions#3683
  2. Move of gogland: move gogland cask (1.0,171.3780.106) from versions #32564

@vitorgalvao
Copy link
Member Author

If one more maintainer agrees, I’d say we can go ahead.

@vitorgalvao
Copy link
Member Author

@victorpopkov Approved on the PRs, so this is resolved.

@leipert
Copy link
Contributor

leipert commented Apr 19, 2017

Fust fyi: Added support to the @jcbot for gogland eap updates with this release: leipert/jetbrains-cask-bot@f74139c

@miccal miccal removed the discussion label Apr 19, 2017
@metyl
Copy link
Contributor

metyl commented Apr 20, 2017

I (and probably other users) like to keep stable version and EAP as separated apps !
To quote Jetbrains: It is important to distinguish EAP from traditional pre-release software. Please note that the quality of EAP versions may at times be way below even usual beta standards. so pushing users to change update channel is not good suggestion.

@leipert
Copy link
Contributor

leipert commented Apr 20, 2017

Unfortunately it seams not feasible to maintain eap casks, as they break on a regular basis. (See discussion above).

I just tried the jetbrains toolbox (brew cask install jetbrains-toolbox) which was mentioned in #32521 (comment). It seems to give a real good access to different versions (either installed via homebrew-cask or the toolbox):

screen shot 2017-04-20 at 17 43 53

EDIT: LOCAL marks casks installed via homebrew-cask and the others are installed via the toolbox. As you can see I installed two different versions of clion (one EAP and one "old") and i could install even more.

@metyl
Copy link
Contributor

metyl commented Apr 21, 2017

First of all there was a problem with only one build of only one cask (phpstorm-eap) so it is hard to say that they break on a regular basis, but the decision was to put all Jetbrains casks into one basket and thrown them away.
There is or rather was community around them and maintenance of these casks went quite well, now all that work and time spent is in a trash bin.

As I understand the whole idea about homebrew and casks: “To install, drag this icon…” no more! is to make install easy, command away not click away!

Jetbrains toolbox is nice addition to Jetbrains products but it is an extra software just to install only Jetbrains products and it is purely GUI applications so to install any app You must click.
I prefer homebrew and casks as a way to install apps because using it I can install not only Jetbrains products and I don't need any extra software to do it.

Imagine situation that now someone heard about latest EAP of eg. IDEA and wants to install using brew cask:

brew cask search intellij eap
No Cask found for "intellij eap".

😕

In Docker You can also switch channel of updates from stable to edge so docker-edge and probably other casks, where You can change update channel in an app, should be removed.

Is this a path caskroom/homebrew-cask and caskroom/homebrew-versions should follow?

@vitorgalvao
Copy link
Member Author

vitorgalvao commented Apr 21, 2017

First of all there was a problem with only one build of only one cask (phpstorm-eap) so it is hard to say that they break on a regular basis

That is incorrect. As stated on the top post (emphasis added):

We even have users that concentrate mostly on those updates, but even then it’s a non-trivial amount of work for maintainers.

I’m one such maintainer and I regularly see EAP casks having to change version and url schemes and names, even with interpolation. They’re constantly being changed to stable versions and back.

Imagine situation that now someone heard about latest EAP of eg. IDEA and wants to install using brew cask

That argument doesn’t hold at all. Imagine someone heard about Audacity or Popcorn Time. Exact same result. Those also have reasons for not being included.

In Docker You can also switch channel of updates from stable to edge so docker-edge and probably other casks, where You can change update channel in an app, should be removed.

Is this a path caskroom/homebrew-cask and caskroom/homebrew-versions should follow?

Are those casks a maintainability strain? No? Then no.

We need to strike a balance. If a few casks take a high toll and have a perfectly acceptable alternative for being managed, then removal is a perfectly valid consideration, especially since taps (which I’ve stated again and again are my favourite HB feature) are a thing.

We’ll eventually see if this is such a disruptive change that a significant number of people ask for it back.

In the meantime, you’re free to create your own tap for Jetbrains EAPs.

@joh-klein
Copy link
Contributor

Does anyone maintain a tap for Jetbrains EAPs?

@leipert
Copy link
Contributor

leipert commented Jul 25, 2017

No, not of my knowledge @joh-klein. I could expand the @jcbot to do that pretty easily.

However I see no real benefit in doing that (for myself). I could be persuaded however if there is pizza and beer involved (See leipert/jetbrains-cask-bot#3)

@lock lock bot locked as resolved and limited conversation to collaborators May 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants