Combine sbarex-qlmarkdown
with qlmarkdown
for compatibility
#114374
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>
is the token of the cask you're submitting.After making all changes to a cask, verify:
brew audit --cask <cask>
is error-free.brew style --fix <cask>
reports no offenses.Additionally, if adding a new cask:
brew audit --new-cask <cask>
worked successfully.brew install --cask <cask>
worked successfully.brew uninstall --cask <cask>
worked successfully.I'm not sure if this is the correct approach, but the problem I'm trying to solve is that the existing
qlmarkdown
is abandoned and does not work on Catalina or later (and this is a known issue), whilesbarex-qlmarkdown
works exclusively with Catalina or later but has limited discoverability.I haven't consulted with either @toland or @sbarex about this, and the README at sbarex/QLMarkdown would need to be updated with the new cask name.
I did
install
anduninstall
on both macOS Big Sur and macOS High Sierra, but I'm not sure if I ran them correctly.brew install --cask path/to/qlmarkdown.rb
on Big Sur reported no errors correctly and correctly installed the application, while on High Sierra it reported no errors but seemingly did not actually install anything. In both casesbrew uninstall --cask path/to/qlmarkdown.rb
worked correctly.