Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

easyfig 2.1.0 (new formula) #12825

Closed
wants to merge 1 commit into from
Closed

Conversation

sjackman
Copy link
Member

Easy genome comparison figures.

EasyFig is a Python application for creating linear comparison figures of
multiple genomic loci with an easy-to-use graphical user interface (GUI).

Easy genome comparison figures.

EasyFig is a Python application for creating linear comparison figures of
multiple genomic loci with an easy-to-use graphical user interface (GUI).
name 'EasyFig'
homepage 'http://mjsull.github.io/Easyfig/'
license :gpl
# desc "Easy genome comparison figures"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of these are supported, won’t for the near future.

@vitorgalvao vitorgalvao self-assigned this Jul 25, 2015
@sjackman
Copy link
Member Author

Will you keep the comments in any case? That's what we've been doing in Homebrew/science. It helps a lot, in fact, to be able to brew cask edit foo and see this information.

# doi "10.1093/bioinformatics/btr039"
# tag "bioinformatics"

app 'Easyfig_mac_2.1/Easyfig_mac_2.1.app', :target => 'EasyFig.app'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:target is inappropriate, here.

@vitorgalvao
Copy link
Member

Thank you for the contribution. It needed some fixes, so they were made in ab9eb40. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.

@vitorgalvao
Copy link
Member

Comments were removed since we don’t intend to become a discoverability service. It is not part of the goals of homebrew-cask. Amongst other things, the logistics are unsustainable.

Keeping comments that are actually unworking code from homebrew makes no sense, especially if only a select few casks have them. We need consistency, now.

On another note, you can brew cask cat <cask_name> to see its contents.

@sjackman
Copy link
Member Author

#{version.to_f}

Nice hack. I haven't seen that one before. It scares me though that to_f doesn't raise an exception when there are unconverted characters.

@sjackman
Copy link
Member Author

Since Homebrew supports desc (and I know they debated this addition for the same reason you mention above), I think Homebrew Cask should also support desc. Why do you support name, if not for discovery?

@sjackman
Copy link
Member Author

Thanks for merging.

@sjackman sjackman deleted the easyfig branch July 25, 2015 18:59
@vitorgalvao
Copy link
Member

Nice hack.

to_f is ugly right now (but it works, and is more readable than gsub) but it should be better in the future.

Since Homebrew supports desc

We’re separate apps with separate maintainers and policies. What works for one does not necessarily work for the other.

I think Homebrew Cask should also support desc.

Not going to happen. At least not in the near future for sure. As I said, the logistics are unsustainable and we have a whole lot of things to worry about before than can even enter into consideration again.

Thanks for merging.

Thank you for the contributions.

@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants