-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Calq #15652
Add Calq #15652
Conversation
@vitorgalvao This Cask is technically okay, but it uses a "horrible hack" so it's questionable if we should merge it (even though we do already have a cask with the same behavior, git-annex) |
Yes, it’s OK to merge, I’d say. |
# This is a horrible hack to force the file extension. The | ||
# backend code should be fixed so that this is not needed. | ||
preflight do | ||
system '/bin/mv', '--', staged_path.join("calq-#{version}"), staged_path.join("calq-#{version}.dmg") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will cause problems on case-sensitive filesystems. Needs to be Calq-#{version}
Hi, Thanks @jawshooah for pointing out. I've made the fix. @adityadalal924 |
@rinopo To clarify, @adityadalal924 wasn’t exactly worried about any harm caused by the cask, but rather that we frown upon these types of hacks (we prefer to fix the core issue). Could you please squash your commits? |
@vitorgalvao Thanks. Squashed. |
Thank you for the contribution. It was merged directly as c61a463 to keep commit history cleaner. Your contribution is still credited to you. |
"Calq is an easy to use, on demand calculator."
I followed
git-annex.rb
to force the.dmg
file extension to the gzipped container. (cf. #3650)