Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Calq #15652

Closed
wants to merge 1 commit into from
Closed

Add Calq #15652

wants to merge 1 commit into from

Conversation

rinopo
Copy link
Contributor

@rinopo rinopo commented Dec 7, 2015

"Calq is an easy to use, on demand calculator."

I followed git-annex.rb to force the .dmg file extension to the gzipped container. (cf. #3650)

@alebcay alebcay added the cask label Dec 7, 2015
@adidalal
Copy link
Contributor

@vitorgalvao This Cask is technically okay, but it uses a "horrible hack" so it's questionable if we should merge it (even though we do already have a cask with the same behavior, git-annex)

@vitorgalvao
Copy link
Contributor

Yes, it’s OK to merge, I’d say.

# This is a horrible hack to force the file extension. The
# backend code should be fixed so that this is not needed.
preflight do
system '/bin/mv', '--', staged_path.join("calq-#{version}"), staged_path.join("calq-#{version}.dmg")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will cause problems on case-sensitive filesystems. Needs to be Calq-#{version}

@rinopo
Copy link
Contributor Author

rinopo commented Dec 13, 2015

Hi,

Thanks @jawshooah for pointing out. I've made the fix.

@adityadalal924
Thank you for your consideration.
I'd argue that this cask shouldn't do any harm at least on the end user's side.
fuse.rb which uses (to my eyes) essentially the same technique has been merged 3 days ago, and there seem to be a few more examples.
And I find calq.app itself is, old it is, still quite useful ;)

@vitorgalvao
Copy link
Contributor

@rinopo To clarify, @adityadalal924 wasn’t exactly worried about any harm caused by the cask, but rather that we frown upon these types of hacks (we prefer to fix the core issue).

Could you please squash your commits?

Fix unmatched case
@rinopo
Copy link
Contributor Author

rinopo commented Dec 13, 2015

@vitorgalvao Thanks. Squashed.

@vitorgalvao
Copy link
Contributor

Thank you for the contribution. It was merged directly as c61a463 to keep commit history cleaner. Your contribution is still credited to you.

@rinopo rinopo deleted the add-calq branch December 14, 2015 02:44
@miccal miccal removed the cask label Dec 23, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants