Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mythic@alpha 0.3.1 #178921

Closed
wants to merge 1 commit into from
Closed

mythic@alpha 0.3.1 #178921

wants to merge 1 commit into from

Conversation

mattmaniak
Copy link

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Initial add of a relatively new open-source Epic Games-supporting launcher. There are some issues however when verifying a new cask listed below.

brew audit --cask --online <cask> and brew audit --cask --new <cask> return

Warning: Removed Sorbet lines from backtrace!
Rerun with `--verbose` to see the original backtrace
audit for mythic@alpha: failed
 - exception while auditing mythic@alpha: Not Found
mythic@alpha
  * exception while auditing mythic@alpha: Not Found
Error: 1 problem in 1 cask detected.

--verbose flag adds nothing but /opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.3.3/bin/bundle clean at the beginning of the output.

@khipp
Copy link
Member

khipp commented Jul 8, 2024

You are seeing the result of the API call to https://api.github.com/repos/MythicApp/Mythic/releases/latest:

{
  "message": "Not Found",
  "documentation_url": "https://docs.github.com/rest/releases/releases#get-the-latest-release",
  "status": "404"
}

Since you only have pre-releases in your repository, try the default git strategy by removing the livecheck block.

@mattmaniak
Copy link
Author

@khipp thanks for the quick response. I removed the livecheck block but GitHub pre-release Error occurs. Also during one of the audit commands an Error about lack of notarization shows up. It's my first cask so as I understand all apps have to be notarized. At least for macOS.

I use Homebrew 4.3.9 on macOS 14.5.

brew audit --cask --new mythic@alpha output:

==> Downloading and extracting artifacts
==> Downloading https://github.com/MythicApp/Mythic/releases/download/v0.3.1/Mythic.zip
Already downloaded: /Users/mateusz/Library/Caches/Homebrew/downloads/439530005b5444ef6e7cf6c7924b11320017e3877cde208ef3a2fa1d5a8166a7--Mythic.zip
==> Downloading https://github.com/MythicApp/Mythic/releases/download/v0.3.1/Mythic.zip
Already downloaded: /Users/mateusz/Library/Caches/Homebrew/downloads/439530005b5444ef6e7cf6c7924b11320017e3877cde208ef3a2fa1d5a8166a7--Mythic.zip
audit for mythic@alpha: failed
 - v0.3.1 is a GitHub pre-release.
 - Signature verification failed:
/private/tmp/cask-audit20240708-19068-swy30f/Mythic.app: rejected

macOS on ARM requires software to be signed.
Please contact the upstream developer to let them know they should sign and notarize their software.
mythic@alpha
  * line 5, col 2: v0.3.1 is a GitHub pre-release.
  * line 5, col 2: Signature verification failed:
    /private/tmp/cask-audit20240708-19068-swy30f/Mythic.app: rejected
    
    macOS on ARM requires software to be signed.
    Please contact the upstream developer to let them know they should sign and notarize their software.
Error: 2 problems in 1 cask detected.

brew audit --cask --online mythic@alpha output:

==> Downloading and extracting artifacts
==> Downloading https://github.com/MythicApp/Mythic/releases/download/v0.3.1/Mythic.zip
Already downloaded: /Users/mateusz/Library/Caches/Homebrew/downloads/439530005b5444ef6e7cf6c7924b11320017e3877cde208ef3a2fa1d5a8166a7--Mythic.zip
==> Downloading https://github.com/MythicApp/Mythic/releases/download/v0.3.1/Mythic.zip
Already downloaded: /Users/mateusz/Library/Caches/Homebrew/downloads/439530005b5444ef6e7cf6c7924b11320017e3877cde208ef3a2fa1d5a8166a7--Mythic.zip
audit for mythic@alpha: failed
 - v0.3.1 is a GitHub pre-release.
mythic@alpha
  * line 5, col 2: v0.3.1 is a GitHub pre-release.
Error: 1 problem in 1 cask detected.

Thanks.

@bevanjkay
Copy link
Member

Thanks for your contribution @mattmaniak - as you have noted the application is not signed and notarized and therefore cannot be included in homebrew-cask.
Consider hosting it in your own tap.

If the application does become signed by the vendor, feel free to resubmit. If the "alpha" version is the most stable release, then the token should just be mythic (for future reference).

@bevanjkay bevanjkay closed this Jul 9, 2024
@mattmaniak
Copy link
Author

Thank you. Will get back when the app will fulfill all the requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants