Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage.rb: Switch mirror; update to v7.2; fix URLs #21353

Merged
merged 1 commit into from
May 21, 2016
Merged

sage.rb: Switch mirror; update to v7.2; fix URLs #21353

merged 1 commit into from
May 21, 2016

Conversation

claui
Copy link
Contributor

@claui claui commented May 21, 2016

Changes to a cask

Editing an existing cask

  • Commit message includes cask’s name (and new version, if applicable).
  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} left no offenses.

Details

For details, see the commit message.

url "http://mirrors-usa.go-parts.com/sage/sagemath/osx/intel/sage-#{version}-OSX_10.11.3-x86_64.app.dmg"
version '7.2'
sha256 '4ede3cac113778e120d233baf702426ffad10905d43afe239c1ea8fd1068697e'
# mit.edu/sage was verified as official since the 7.2 version bump
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Message needs to remain as it was. It’s standard.

@vitorgalvao vitorgalvao added the awaiting user reply Issue needs response from a user. label May 21, 2016
@claui
Copy link
Contributor Author

claui commented May 21, 2016

Thanks @vitorgalvao! Fixed.

version '7.1'
sha256 'ce900a39dd1a4c33cec40a3c2fde81cf4a4446a7d8b3985041b501b9d88f8471'
version '7.2'
sha256 '4ede3cac113778e120d233baf702426ffad10905d43afe239c1ea8fd1068697e'
# go-parts.com/sage was verified as official when first introduced to the cask
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the confusion. I meant it should be # mit.edu/sage was verified as official when first introduced to the cask. Changing the first part was correct, only the rest of it should have remained.

The latest stable version of SageMath is [7.2](http://mirrors.mit.edu/sage/osx/intel/index.html) and can be found on the MIT mirror.

Currently, the El Capitan branch of this cask is broken because it points to [go-parts.com](http://mirrors-usa.go-parts.com/sage/sagemath/osx/intel/), a mirror which seems not to carry neither the stable 7.1 version nor the current stable v7.2.

The site is also not part of the [list of download servers on sagemath.org](http://www.sagemath.org/download-mac.html). Because of this, I switched the El Capitan branch to point to mirrors.mit.edu/sage just like the other branches do.

This commit also updates broken URLs for the Mavericks and Yosemite branches.

http://mirrors.mit.edu/sage/osx/intel/sage-7.2-OSX_10.11.4-x86_64.tar.bz2

This cask also happens to symlink a binary which lives inside the moved artifact. So this is one of the cases where we might want to use the new `appdir` method that is being introduced in #13966.
@claui
Copy link
Contributor Author

claui commented May 21, 2016

Here we go!

@vitorgalvao
Copy link
Member

Thank you.

@vitorgalvao vitorgalvao merged commit 54ee18c into Homebrew:master May 21, 2016
@claui claui deleted the update-sage branch May 21, 2016 20:23
chizmw pushed a commit to chizmw/homebrew-cask that referenced this pull request Jun 15, 2016
The latest stable version of SageMath is [7.2](http://mirrors.mit.edu/sage/osx/intel/index.html) and can be found on the MIT mirror.

Currently, the El Capitan branch of this cask is broken because it points to [go-parts.com](http://mirrors-usa.go-parts.com/sage/sagemath/osx/intel/), a mirror which seems not to carry neither the stable 7.1 version nor the current stable v7.2.

The site is also not part of the [list of download servers on sagemath.org](http://www.sagemath.org/download-mac.html). Because of this, I switched the El Capitan branch to point to mirrors.mit.edu/sage just like the other branches do.

This commit also updates broken URLs for the Mavericks and Yosemite branches.

http://mirrors.mit.edu/sage/osx/intel/sage-7.2-OSX_10.11.4-x86_64.tar.bz2

This cask also happens to symlink a binary which lives inside the moved artifact. So this is one of the cases where we might want to use the new `appdir` method that is being introduced in Homebrew#13966.
@adidalal adidalal removed the awaiting user reply Issue needs response from a user. label Jul 2, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants