Check arguments individually in brew cask list.
#22031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claui
added
bug
Fixes part 1 of #14058.
| @@ -23,6 +23,7 @@ def self.sources | |||
|
|
|||
| def self.for_query(query) | |||
| odebug "Translating '#{query}' into a valid Cask source" | |||
| raise Hbc::CaskUnavailableError.new(query) if query.to_s =~ /^\s*$/ | |||
There was a problem hiding this comment.
Update: Fixed as of your latest commit.
This breaks brew cask list for me:
https://cloud.githubusercontent.com/assets/1239874/16128846/942e81a2-3402-11e6-8166-b2c969593847.png
claui
added
the
awaiting maintainer feedback
|
Thanks for your contribution @reitermarkus! Looks good to me 👍 |
|
You're welcome! 😃 |
|
@claui Feel free to merge these when you’re happy with the submissions (not sure if you’d like to wait for more people to look at it and comment, but I’m fine with it). |
claui
removed
the
awaiting maintainer feedback
miccal
removed
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to the core
Fixes part 1 of #14058.