Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move fonts instead of hardlinking them #23728

Merged
merged 1 commit into from
Aug 12, 2016
Merged

Move fonts instead of hardlinking them #23728

merged 1 commit into from
Aug 12, 2016

Conversation

jawshooah
Copy link
Contributor

@jawshooah jawshooah commented Aug 12, 2016 •
edited
Loading

Changes to the core

Also get rid of the Hardlinked class, and merge Linked with Symlinked.

Closes #23723

@jawshooah jawshooah added core Issue with Homebrew itself rather than with a specific cask. bug Issue describing a reproducible bug. labels Aug 12, 2016
@jawshooah
Copy link
Contributor Author

@reitermarkus Looks like there's a race condition of some kind in cleanup_spec; it only failed in one of the two Travis jobs.

@reitermarkus
Copy link
Member

@jawshooah, might be because the file is locked non-blockingly.

@jawshooah jawshooah mentioned this pull request Aug 12, 2016
Merged
1 task
@jawshooah jawshooah merged commit 9ce6a95 into Homebrew:master Aug 12, 2016
@jawshooah jawshooah deleted the move-fonts branch August 12, 2016 19:15
jedahan pushed a commit to jedahan/homebrew-cask that referenced this pull request Sep 24, 2016
@jawshooah
Move fonts instead of hardlinking them (Homebrew#23728)
58bc027
@miccal miccal removed bug Issue describing a reproducible bug. core Issue with Homebrew itself rather than with a specific cask. labels Dec 23, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jawshooah @reitermarkus @miccal