Update xnconvert to 1.74 #31988
Closed
Update xnconvert to 1.74 #31988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorpopkov
reviewed
Apr 6, 2017
| @@ -1,6 +1,6 @@ | |||
| cask 'xnconvert' do | |||
| version :latest | |||
| sha256 :no_check | |||
| version '1.74' | |||
There was a problem hiding this comment.
There is no need in this change. Seeing as url doesn’t point to a specific version, this cask should use version :latest and sha256 :no_check.
gobinathm
reviewed
Apr 6, 2017
| @@ -1,6 +1,6 @@ | |||
| cask 'xnconvert' do | |||
| version :latest | |||
| sha256 :no_check | |||
| version '1.74' | |||
There was a problem hiding this comment.
@tiiiecherle its does not seems to have any significant in this change. The URL is staying same so the version stanza should :latest & sha256 should :no_check as before
|
The same thing applies to other PRs as well. Thank you for your contributions, but there is no need for all those changes if the download URL doesn't point to any specific version. |
This was referenced Apr 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After making all changes to the cask:
brew cask audit --download {{cask_file}}is error-free.brew cask style --fix {{cask_file}}left no offenses.