Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update caveats for google-cloud-sdk #32124

Merged
merged 1 commit into from
Apr 9, 2017
Merged

Update caveats for google-cloud-sdk #32124

merged 1 commit into from
Apr 9, 2017

Conversation

commitay
Copy link
Contributor

@commitay commitay commented Apr 9, 2017

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Removed fish completion instructions from caveats. Closes #30847.

Fish completions have been removed from the unversioned url download.

While they are included in a versioned alternative I don't see how to make this a versioned cask without users having to update their profiles with each new version or using postflight to create symlinks somewhere so as to have a static path to the completions.

source '/usr/local/Caskroom/google-cloud-sdk/latest/google-cloud-sdk/completion.bash.inc'

@vitorgalvao vitorgalvao merged commit 84ae58b into Homebrew:master Apr 9, 2017
@commitay commitay deleted the google-cloud-sdk branch April 9, 2017 09:27
@Homebrew Homebrew locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug report: google-cloud-sdk fish completion instructions are wrong
2 participants